salt-ds
salt-ds copied to clipboard
jpmorganchase
Slider
Updates Slider component to new designs and behaviours.
Highlights:
Integration with Input
Support for custom step amount
Full "range" support
🦋 Changeset detected
Latest commit: c2dcfde811e9d5db2e6ed990c955a74c29dca97f
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @salt-ds/lab | Minor |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| saltdesignsystem | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 10, 2024 9:10pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Storybook Preview Link https://402bc2d1.saltdesignsystem-storybook.pages.dev
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
With latest change, tooltip will not show when 1) mouse on the exact middle of the bar 2) off the track, is this intended behavior change? Previously i heard the tooltip needs to be visible after drag begins
@tomhazledine Design review complete. Can be found here: https://www.figma.com/design/JedClmXUirW6MG7OluTRGN/Slider?node-id=3180-461&t=5NCWiKeSlCexyPBT-1
A few comments, mostly on content. But just wanted to raise them so they're not lost.
There's a minor annoyance for me when using slider. Having to keep the mouse over the slider when dragging isn't a great UX cc @navkaur76
Have address most of the content questions/updates. Will defer to @navkaur76's expertise re: the a11y wording
Made a change to allow the mouse drag to continue without needing to be over the actual element. Led to a dev question that I've raised in the FED teams chat
