salt-ds
salt-ds copied to clipboard
jpmorganchase
Ag grid next v31
⚠️ ❗ Do not merge this before #3364 is released
Next major update to support ag grid v31
- New AG grid variables support
- Removed UITK theme
- Massively reduce bundle size from 1,600 kB to < 25 kB
To use / test
Latest snapshot:
-@salt-ds/[email protected]
-@salt-ds/[email protected]
Test bed on StackBlitz: https://stackblitz.com/edit/salt-ag-grid-theme-mgguyf?file=App.jsx
Import css
import "ag-grid-community/styles/ag-grid.css"; // Updated from ag grid
import "@salt-ds/ag-grid-theme/salt-ag-theme.css"; // Changed from `/salt.css` from early v30 snapshot
Class names on container changed, e.g.
.ag-theme-salt-light
.ag-theme-salt-compact-light
- [ ] Review site doc
Reported issues
- [x] floating filter double lines
- [x] side bar custom component auto width
- [x] status bar vertical alignment
- [x] loading overlay background
- [x] cell range background color (gray, needing new token)
- [x] Confirm regression of #3290
- [x] New icon set needed (https://ag-grid.com/javascript-data-grid/custom-icons/#provided-icons)
- [x] Confirm regression of #3351
🦋 Changeset detected
Latest commit: 8ff3ec808a001217b329208bab64c9a10222bc0e
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
| Name | Type |
|---|---|
| @salt-ds/theme | Minor |
| @salt-ds/ag-grid-theme | Major |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| saltdesignsystem | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 24, 2024 1:42pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
🫰✨ Thanks @origami-z! Your snapshots have been published to npm.
Test the snapshots by updating your package.json with the newly published versions:
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
🫰✨ Thanks @origami-z! Your snapshots have been published to npm.
Test the snapshots by updating your package.json with the newly published versions:
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
🫰✨ Thanks @origami-z! Your snapshot has been published to npm.
Test the snapshot by updating your package.json with the newly published version:
yarn add @salt-ds/[email protected]
🫰✨ Thanks @origami-z! Your snapshot has been published to npm.
Test the snapshot by updating your package.json with the newly published version:
yarn add @salt-ds/[email protected]
🫰✨ Thanks @origami-z! Your snapshots have been published to npm.
Test the snapshots by updating your package.json with the newly published versions:
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
🫰✨ Thanks @origami-z! Your snapshots have been published to npm.
Test the snapshots by updating your package.json with the newly published versions:
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
🫰✨ Thanks @origami-z! Your snapshots have been published to npm.
Test the snapshots by updating your package.json with the newly published versions:
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
🫰✨ Thanks @origami-z! Your snapshots have been published to npm.
Test the snapshots by updating your package.json with the newly published versions:
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
🫰✨ Thanks @origami-z! Your snapshots have been published to npm.
Test the snapshots by updating your package.json with the newly published versions:
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
🫰✨ Thanks @origami-z! Your snapshots have been published to npm.
Test the snapshots by updating your package.json with the newly published versions:
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
🫰✨ Thanks @origami-z! Your snapshots have been published to npm.
Test the snapshots by updating your package.json with the newly published versions:
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
🫰✨ Thanks @origami-z! Your snapshots have been published to npm.
Test the snapshots by updating your package.json with the newly published versions:
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]