q icon indicating copy to clipboard operation
q copied to clipboard

Published 20 hours ago • verified publisher icon jpmonette

Escape backslash

Open fehays opened this issue 5 years ago • 7 comments

fehays avatar Feb 20 '20 17:02 fehays

@fehays It seems like this PR's scope is much bigger than simply escaping backslash, no? Is it possible to break it down as I think the escaping backslash is a good addition, but there is probably room for discussing other changes.

Thanks

jpmonette avatar Apr 15 '20 20:04 jpmonette

@jpmonette My mistake. I accidentally committed some other enhancements to this branch that I did not intend for this PR.

fehays avatar Apr 15 '20 20:04 fehays

@jpmonette I've reverted the commits and published a new branch in my forked repo with the changes for supporting allowing parenthetical groupings of logical operators (https://github.com/fehays/q/tree/conditional-groups). Let me know if you want to discuss that enhancement

fehays avatar Apr 15 '20 21:04 fehays

@fehays Do you mind just adding some simple tests to evaluate scenarios and then we should be good to go.

Thanks for the contribution!

jpmonette avatar Apr 15 '20 21:04 jpmonette

@jpmonette Done. Thanks!

fehays avatar Apr 15 '20 23:04 fehays

@fehays Quick update on my previous comment - if you could review.

jpmonette avatar May 01 '20 21:05 jpmonette

@jpmonette Sorry, I may have missed a comment. What would you like me to review?

fehays avatar May 01 '20 22:05 fehays