feed icon indicating copy to clipboard operation
feed copied to clipboard

Implement "isPermaLink" for item:guid

Open neopostmodern opened this issue 5 years ago • 9 comments

item:guid has to be a URL unless the isPermaLink attribute is set to false. I've added this functionality targeting RSS 2.0 and updated tests (for which I need to mangle types a bit -- did these tests pass before I checked them out?) I believe that the behavior for Atom could/should be updated in some way, because it allows non-URL item:id values (Example), but which wouldn't be allowed in RSS 1.0. But this would cause major infrastructure-changes I guess, wheres just adding the isPermaLink attribute should be non-breaking.

neopostmodern avatar Mar 20 '19 08:03 neopostmodern

Coverage Status

Coverage increased (+0.6%) to 96.316% when pulling 893e463b993f00161622a4c66c115af4b6411475 on neopostmodern:master into 919ad32e4e71617362bf34c3bb169fdf0c7246f2 on jpmonette:master.

coveralls avatar Mar 20 '19 08:03 coveralls

Please add this

dainissilamikelis avatar Aug 26 '20 14:08 dainissilamikelis

@neopostmodern, I've solved all conflicts in a new PR (https://github.com/jpmonette/feed/pull/177) to speed up the merge of this feature. I don't want to steal your job or take advantage of it. Please, let me know if you want me to solve conflicts in your master branch so your PR will be ready to merge.

senechaux avatar Jul 18 '22 10:07 senechaux

@senechaux Thanks for your effort. I've just merged the master into my repo again – if that is good to go I'd be happy to use this PR; if it isn't I don't mind using yours instead either. Most of all we need someone who can merge this – @youssmoh, @jpmonette, who could take care of this?

neopostmodern avatar Jul 18 '22 15:07 neopostmodern

@youssmoh, @jpmonette, is it possible to merge this PR? it's already been approved.

senechaux avatar Aug 16 '22 08:08 senechaux

Please integrate this :+1:

marco-msg-ferrari avatar Sep 12 '22 14:09 marco-msg-ferrari

@youssmoh, @jpmonette, please, let me know if there is something I can help to merge this PR

senechaux avatar Sep 19 '22 08:09 senechaux

Please integrate this

antiantivirus avatar Mar 01 '23 14:03 antiantivirus