prow-github-actions icon indicating copy to clipboard operation
prow-github-actions copied to clipboard

Refactor: Bring everything up to speed with new deps and node 20

Open neutronth opened this issue 9 months ago • 2 comments

Refactor: Bring everything up to speed with new deps and node 20

  • Based on works of John McBride (@jpmcb)
  • Update dependencies:
    • Bump:
      • @typescript-eslint/eslint-plugin: ^6.7.0
      • @typescript-eslint/parser: ^6.7.0
      • eslint: ^8.49.0
      • typescript: ^5.2.2
    • Add:
      • eslint-import-resolver-typescript: ^3.6.0 Required for eslint to work with typescript import resolver
      • msw: ^1.3.1 Introduced to replace nock
    • Replace deprecated:
      • Replace @zeit/ncc with @vercel/ncc, upstream suggestion Build error: digital envelope routines::unsupported
    • Drop:
      • nock due to the issue [1] related to the fetch experimental feature of nodejs
  • Refactor code:
    • TypeScript compile errors
    • ESLint errors and warnings
    • Tests reimplement GitHub API responses mockup using msw/node instead of nock
  • Declare the action runs using node20

[1] https://github.com/nock/nock/issues/2397

neutronth avatar Sep 17 '23 12:09 neutronth

Closes https://github.com/jpmcb/prow-github-actions/issues/73 Closes https://github.com/jpmcb/prow-github-actions/pull/79

jpmcb avatar Sep 17 '23 17:09 jpmcb

Any updates on this effort? I am interested in this action

ArangoGutierrez avatar Jan 29 '24 10:01 ArangoGutierrez