JPlag icon indicating copy to clipboard operation
JPlag copied to clipboard

Feature/cli module refactoring

Open TwoOfTwelve opened this issue 2 years ago • 2 comments

Contains a big refactoring of the cli module. In specific:

  • Minor refactoring all over the module based on Intellijs code analysis.
  • A rewrite of the CollectedLogger class, because the base interface we used is deprecated since 2020.
  • The CLI class has been split up into multiple classes.
  • The CLI class now uses interfaces for access to JPlag. This can be used to write more and better unit tests.

TwoOfTwelve avatar Feb 23 '24 09:02 TwoOfTwelve

The three remaining sonarcloud issues already existed and cannot be fixed. Unless we want to remove the legacy support for the old submission directories.

TwoOfTwelve avatar Feb 23 '24 10:02 TwoOfTwelve

@tsaglam could you take another look at this?

TwoOfTwelve avatar Apr 02 '24 08:04 TwoOfTwelve

I have tested it with a short example. The formatting of the log output might have changed slightly, but the content is definitely still the same.

TwoOfTwelve avatar Apr 09 '24 13:04 TwoOfTwelve