chisel icon indicating copy to clipboard operation
chisel copied to clipboard

add timeout for keepalive reply

Open ximiximi1 opened this issue 1 year ago • 4 comments

The sshConn.Send Request will send message and block wait the reply. The keepalive will not work in some special condition. For example, when the server use memory snapshot to hibernate and did not close the socket normally and there is a websocket middware like Cloudflare to proxy the websocket, when the server hibernate with memory snapshot, Cloudflare will not close the websocket connection during a very long time(this maybe a issue of Cloudflare), in the mean while, the keepalive block wait the reply(there will not have a reply as server hibernated), as a result, the ssh connection will not close until the Cloudflare close the websocket(very long time above 10min). So I add a reply timeout for the keepalive. A timeout error will raise when wait the keepalive reply too long, and then close the ssh connetion.

ximiximi1 avatar Aug 20 '23 06:08 ximiximi1

Thanks this is a good change - will try get a sec to test it soon

jpillora avatar Aug 20 '23 06:08 jpillora

Hey, Is this going to merge anytime soon? Thanks!!

linus-gates avatar Dec 24 '23 18:12 linus-gates

@jpillora We are experiencing the same issues described here, and this PR will resolve them. Could you please review and merge the PR?

OS-kiranmalsetty avatar Aug 06 '24 16:08 OS-kiranmalsetty