jpfinne

Results 19 comments of jpfinne

> It would be great if @wing328 or someone from the Java technical committee could take over reviewing this PR; both to add another perspective and because I currently can't...

@MelleD a bit overkill when knowing the implementation. But let's imagine we want blackbox testing, if it can speed up the approval and the merge... I've tested your 3 uses...

I don't think JsonTypeName is needed as Jackson has all the required annotations. ``` @ExtendWith(SpringExtension.class) @AutoConfigureJson class TestInheritance { @Autowired ObjectMapper objectMapper; @Test void dog() throws IOException { Dog dogA...

@martin-mfg I now understand you want `@JSonTypeName` on the parent class. According to [JsonTypeName](https://www.javaguides.net/2023/10/java-jackson-jsontypename.html#:~:text=The%20%40JsonTypeName%20annotation%20allows%20developers,type%20in%20the%20serialized%20JSON) only subTypes need it > The @JsonTypeName annotation allows developers to specify a custom name for...

@wing328 Sorry my mistake, in testAllVars_issue_18340() I made a stupid typo with an extra space for " true". ``` Map.of("REFACTOR_ALLOF_WITH_PROPERTIES_ONLY", " true") ``` Sorry that the typo is now on...

An other workaround is `x-enum-varnames` in the contract. https://openapi-generator.tech/docs/templating/#all-generators-core Still a PITA to have such a change in a minor version