Julianus Pfeuffer comments

Results 1002 comments of


                                            Julianus Pfeuffer

Core dump for AssayGeneratorMetabo

Probably related to #7000 : Sirius requires setting a username and password by now.

Core dump for AssayGeneratorMetabo

The params for AGM are: - sirius_user_password - sirius_user_email

Core dump for AssayGeneratorMetabo

Do they work though? 😄 I found them on the tool docs.

Core dump for AssayGeneratorMetabo

@timosachsenberg Any idea? Wrong merge? Wrong tag? M Bernt ***@***.***> schrieb am Mi., 25. Okt. 2023, 13:21: > Also wondering also why the tests are active (not commented) on branch...

Error in the msstats_tmt.R function parse_contrasts

@kai-lawsonmcdowall Please let us know if your merged PR fixed that problem. Thanks for the contribution.

The sdrf file check for 'sdrf' in the filename seems arbitrary

I actually think that part of the code checks if we have an sdrf vs the also supported openms-specific design which is also a csv format. Either we drop support...

Think about building develop from time to time for ccache

Any thoughts about that @timosachsenberg @poshul

Think about building develop from time to time for ccache

I think one wouldn't need the nightly cache anymore. Starting from the first build on a PR, a PR has its own cache anyway so no problem if sth happens...

Think about building develop from time to time for ccache

The nightly action would need to build (additionally?) from develop though

Think about building develop from time to time for ccache

Basically yes. We would need to make sure that no logic depends on the name of the branch being nightly and instead maybe solely rely on the type of build...