squaremap icon indicating copy to clipboard operation
squaremap copied to clipboard

Feedback wanted: show_x url params persist when copying link

Open jpenilla opened this issue 1 year ago • 3 comments

When using the link ui to copy a link, the params for hiding and showing elements are persisted. Not 100% sure if this is desirable, there is valid reasoning for both ways. Should we add another parameter to control this, keep it, or revert it (not persist)? Please comment if you have thoughts on this.

see #315

jpenilla avatar Oct 17 '24 19:10 jpenilla

I think it should persist the show_x stuff, because its pretty annoying typing it out everytime + right now you type it out manually

Chucky3920 avatar Oct 17 '24 20:10 Chucky3920

The reason I was thinking it shouldn't persist would be if someone disabled all the UI elements except for the link button, they may want to use it as a way to get a link to the full map as opposed to the iframe view with elements disabled. Since you think we should keep the persistence, maybe a separate parameter to control this would be best.

jpenilla avatar Oct 17 '24 20:10 jpenilla

Sure, I just needed this for my iframe because my iframe is tiny and the sidebar and stuff just clutters the screen when it's 150x150px

Chucky3920 avatar Oct 17 '24 20:10 Chucky3920