Tile foliage colour changes regardless of biome

[Brottweiler]

I have generated a new map and generated squaremap and all looked good. Over time as people travel and load chunks, the colour of the foliage (grass, leaves...) changes. It is most noticeable in Savanna biomes because the brown grass turns bright green.

This server is running Paper version 1.21.1-52-master@e08e667 (2024-08-26T18:02:06Z) (Implementing API version 1.21.1-R0.1-SNAPSHOT)
squaremap version 1.2.7

[jpenilla]

If you run a radius render in that area does it fix itself? If so it's likely another plugin messing with world state in an unsafe manner

[Brottweiler]

I went to the area (where the pumpkins are, the orange pixels top left area) and ran /squaremap radiusrender minecraft:overworld 3 ~ ~ and refreshed the map and the tiles are still coloured wrong.

[jpenilla]

That implies something is wrong with the world data itself, if you can share the affected region files I can have a look later

[Brottweiler]

It's weird because in game it's still a savanna biome. Some backstory, we had a previous world and suddenly I noticed a green tile in a Savanna biome (most noticeable). We were going to reset the world anyway so I thought there was some update of the plugin that caused this, so maybe if I made a new render it would be fine.

Then we made a new world and made a render and it looked fine, until we started playing and we noticed tiles changing colour to bright green.

So it started happening on the old world, and happens immediately on this new world. I have attached the region file that contains the chunk with the pumpkins (as the debug menu tells me) here: https://www.dropbox.com/scl/fi/w7pam3oc6p1iuf1skf33k/r.0.0.mca?rlkey=12z3qo3bp39ocub8w7sfggod5&st=zicogz99&dl=0

[jpenilla]

Strangely the area rendered fine for me, even after building in it to trigger background renders:

I also tried a second time with spawn chunks disabled to see if there was a difference based on whether squaremap was using an already loaded chunk or requesting the load itself, and it did not make a difference.

What other plugins & datapacks do you have installed? Could you test without them for good measure? Also please share your plugins/squaremap/advanced.yml and plugins/squaremap/config.yml.

[Brottweiler]

I'll do some additional testing soon but I'm the meantime these are my plugins.

[04:14:34 INFO]:  - Admin-Chat, Chunky, CommandHelper, CoreProtect, Essentials, EssentialsChat, EssentialsGeoIP, FreedomChat, GriefPrevention, GrimAC
[04:14:34 INFO]:  InventoryRollbackPlus, LuckPerms, *ModReq, OpenInv, ProtocolLib, PvPManager, squaremap, squaremap-griefprevention, squaremap-vanish, squaremap-worldguard
[04:14:34 INFO]:  VanishNoPacket, Vault, WorldEdit, WorldGuard

[Brottweiler]

config.txt (it became .txt after I downloaded it from GitHub on phone) Here's the config (I hope this works because I'm on mobile right now). advanced.yml I have never edited but once I can connect to the server I will share it.

[Brottweiler]

advanced.txt Here is advanced.yml (github doesn't accept uploading yml files). I have never edited it.

[Brottweiler]

Well this is very interesting! I tried modify a chunk and it turned green, so I deleted advanced.yml and let squaremap generate a new one, then I re-rendered the entire map (deleted the tiles and rendered new ones) and now all savanna is green.

So when I originally rendered the map, savanna had proper colour. Then over time it turned green (plains turned green too, but it was less noticeable). Now when rerendering the map all savanna is green.

Could it still be that a plugin interferes with squaremap?

[jpenilla]

Given my inability to reproduce this so far, I'm not sure. Like I said before it would be worthwhile to test a fresh Paper server with only squaremap installed and one of the problematic region files copied in. This would isolate if it's something to do with the server or your system in general.

[Brottweiler]

Hello again, I tried to find time to test this but I never got around to it, but I noticed this very odd thing where the savanna chunks started to become savanna-coloured as people were exploring and updating them again. So I re-rendered the map and now it's correct colour. The only thing that has changed would be the paper version because I occasionally update to a new build... But I will close this for now.

[Brottweiler]

It is starting again, and I'm just posting this here for reference since I still don't know what causes this. But it might not be squaremap since squaremap just reports what it gets from the server. It's really odd..

This server is running Paper version 1.21.1-123-master@aebbdc9 (2024-10-16T14:15:18Z) (Implementing API version 1.21.1-R0.1-SNAPSHOT)
squaremap version 1.2.7

[cheonghour]

I’m having the same issue. At first, the savanna area was rendering fine in yellow, but then some chunks randomly turned green. After running a full render, every savanna area turned green.

I was using the Dynmap plugin at first, but switched to squaremap due to severe performance issues. I’m not using any other plugins.

I'm using paper 1.21.3 build 82, and squaremap version is 1.3.3

[Brottweiler]

I'll reopen this issue since it seems to affect others, with only paper+squaremap.

I am still affected, I noticed two yellow savanna squares turned green, but then one of them turned back to yellow by itself.

[cheonghour]

I'm still experiencing the same issue after switching to a Fabric 1.21.4 server and squaremap 1.3.4.

[TothAdam0012]

I'm in 1.21.4 and have the same issue. I had this with previous versions too. The common thing is that the savanna renders fine at first every single time and after some time it changes to green.

[Nachtnebel]

same problem here, paper 1.21.4, worked fine and after a few days it started to shift with that squares, a new fullrender made all savanna in that green. problem seems to be that it takes the wrong color for that biome, but still correctly gets what biome it is. we "fixed", rather circumvented, the problem, by just forcing the savanna foliage colors from wiki manually in the foliage color overrides of the advanced settings. so this works and it fixed the problem for now:

minecraft:savanna: '#aea42a' minecraft:savanna_plateau: '#aea42a' minecraft:windswept_savanna: '#aea42a'

so from that point, i would say, because forcing savanna colors fixes it, the plugin correctly recognizes the biome as savanna, but somehow assigns the wrong color to it, rather than missing what biome it is. maybe that observation helps.

[jpenilla]

If you are affected please enable debug-mode in config.yml, and share logs using the actions artifact from https://github.com/jpenilla/squaremap/pull/361 (latest is currently at https://github.com/jpenilla/squaremap/actions/runs/12857644809/artifacts/2453564036)

If we're lucky this could point me in the direction of reproducing the bug locally, which would be the first step to a fix. Thanks for the pointer @Nachtnebel

[Nachtnebel]

so, remove the overrides i did, use that new version and wait until it starts again, right? or is the default stuff already logged completely even when i override the colors, so no need to change the config? will do that later, its time for bed now. if no answer until then, i will try with the overrides in first, until you want me to remove them.

[jpenilla]

There's no need to change the config beyond enabling debug logging.

[Nachtnebel]

so, shortly now, i did it on our server as well as on a new local clean without any other plugins. both give the same [DEBUG] minecraft:savanna | 1.0 | 0.0 | #BFB755FF | #939E23FF | #3F76E400 [DEBUG] minecraft:savanna_plateau | 1.0 | 0.0 | #BFB755FF | #939E23FF | #3F76E400 [DEBUG] minecraft:windswept_savanna | 1.0 | 0.0 | #BFB755FF | #939E23FF | #3F76E400

the colors seem fine, although different from the wiki that lists

Grass color | #bfb755 Foliage color | #AEA42A Water color | #3F76E4‌ [JE]

so foliage seems off, but the color seems fine and not the wrong green. also, wiki lists temperature as 2.0 in java for all. 1.0 is never correct not even before the change in 1.18 nor in bedrock.

what i now think from how it was for us. we started with a experimental paper build in 1.21.4 and jumped across several versions while updating, and other people having even different versions of mc and you being unable to reproduce it, we probably have two scenarios

1. random versions and plugin combinations are affected (rather unlikely)
2. since version jumping means several restarts, it could mean, that sometimes it just fails to get the correct number when starting, so what i will try next is, since i have all our old logs, get the versions we used and just jump again through the versions and so restarting it, as well as just restarting the server many times per version and see if sometimes the colors are wrong.

also maybe a discord for contact or so, might be easier in the future. also im not that familiar with github and openly posting the whole log feels kinda bad, so idk how to send it privately when no discord or so

[jpenilla]

The Discord is linked in the readme, https://discord.gg/PHpuzZS, my user is jmp_

The temperature and humidity are clamped between 0 and 1 and then used to select a color from the appropriate image, this is the same way the client does it.

[GFJHogue]

Same issue on purpur-1.21.5-2434 with squaremap-paper-mc1.21.5-1.3.6. We just started our server this week, so never any version changes.

When I first installed the plugin, the only thing I did was tweak config for water transparency/checkering. Then when I ran an initial fullrender, all of the colours were initially correct. Eventually chunks started appearing with the incorrect green shades, after event-triggered renders.