TabTPS icon indicating copy to clipboard operation
TabTPS copied to clipboard

[Feature Request] Folia support

Open sofianedjerbi opened this issue 1 year ago • 4 comments

It would be great to have folia support. I'm going to create a PR, so here is a little Feature Request.

sofianedjerbi avatar Apr 02 '23 20:04 sofianedjerbi

With a regionized server, global MSPT/TPS doesn't make sense as a concept.

Displaying information for all regions in the displays would be cluttered to the point where it becomes useless.

The best I think we could sensibly do is display information for the player's current region. If anyone has a proposal for something more extensive, feel free to share, but if it's too cluttered it won't be accepted.

Anyways, there's a lot more to monitor with Folia than with Paper or other supported platforms, and if you have a use case where Folia makes sense, you should probably be using something like UnifiedMetrics anyways.

jpenilla avatar Apr 02 '23 20:04 jpenilla

I was going to add/change the following modules:

tps: Current region TPS mean_tps: Mean TPS on Folia median_tps: Median TPS on folia

Same with MSPT

sofianedjerbi avatar Apr 02 '23 21:04 sofianedjerbi

I would prefer naming like current_region_tps regions_mean_tps and etc. Would probably want min and max too.

As for the existing tps and mspt modules, I think we should just have them delegate to the current_region equivalent when running on Folia.

Another thing is the tick info command should not be registered on Folia. Folia's built-in command is good enough that we don't need to waste effort implementing that.

jpenilla avatar Apr 02 '23 21:04 jpenilla