TabTPS icon indicating copy to clipboard operation
TabTPS copied to clipboard

Take into account Minecraft version for update checks on Fabric

Open Lentern opened this issue 4 years ago • 2 comments

Describe the bug An update for TabTPS is prompted in the console every time the server starts even when the updated mod version is for a different Minecraft version

To Reproduce

  1. Add TabTPS 1.3.10 to 1.17.1 Fabric server
  2. Start it
  3. Watch the console; notice how it prompts you to update despite the mod being for a newer version of Minecraft

Expected behavior No update prompt will appear

Screenshots image

Server Software and Version:

  • Vendor: Fabric
  • Minecraft Version: 1.17.1

Lentern avatar Dec 05 '21 01:12 Lentern

The update checker can be disabled (update-checker in the main config file), and that would be my recommendation, to disable it once the Minecraft version you're running can't use the new update.

Sure, the update checker could be improved, but it's quite low priority for me, especially given Fabric is the only platform MiniMOTD supports which has a version-specific artifact (the Spigot, Bungee, Velocity, and Sponge plugins are tied to API versions, not Minecraft versions, and so you can usually always run the latest plugin version)

jpenilla avatar Dec 05 '21 01:12 jpenilla

The update checker can be disabled (update-checker in the main config file), and that would be my recommendation, to disable it once the Minecraft version you're running can't use the new update.

Sure, the update checker could be improved, but it's quite low priority for me, especially given Fabric is the only platform MiniMOTD supports which has a version-specific artifact (the Spigot, Bungee, Velocity, and Sponge plugins are tied to API versions, not Minecraft versions, and so you can usually always run the latest plugin version)

# Should the plugin check GitHub for updates on startup?
update-checker=false

I made the above configuration, the updater still enabled and was not disabled as expected.

csthenry avatar Jan 08 '24 02:01 csthenry