Jonathan Peffer

Results 18 comments of Jonathan Peffer

@bodiam I have opened PR https://github.com/datafaker-net/datafaker/pull/215 to support further discussion. Let me know if you have any questions. I wasn't too sure if you would be open to a breaking...

Certainly there are a few options that come to mind. I shared my thoughts in the PR. Let me know what you think. The first iteration was just to help...

I was working on some refactoring to address your concerns and got a little confused about the responsibility of Faker and FakeValuesService. Many of the methods in the FakeValuesService are...

@epragtbeamtree, @bodiam I've opened a new PR that aims to address not breaking the existing API, but lays a foundation for decoupling the data providers from the single Faker instance....

Are there concerns with the PR I put together in PR #221? I believe the refactor introduces a number of desirable changes to the structure and extensibility of the code.

Unfortunately #222 does not address the original need entirely. I do however like the idea of passing in a seed to doWith, but I still believe setting an immutable seed,...

@bodiam I tend to agree that the API in its current state may become problematic. The Faker class will become more and more polluted over time. I think splitting things...

Any idea when this might be picked back up? This would be a useful addition and seems to be fairly common practice.