Visual issues introduced with merge of yakuza branch

[boberto5888]

Last Tested On January 22, 2019 - https://github.com/jpd002/Play-/commit/20113e02

The merge of the yakuza branch caused visual issues in a number of games, examples of these visual issues can be found below.

Game	Visual Issue (click text to reveal image)
007: Everything or Nothing	Blue tint
Ace Combat 4	Blue tint, red tinted images/symbols overlaying screen
Berserk	Blue tint, red tinted images/symbols overlaying screen
DBZ Budokai Tenkaichi 2 & 3	Light blue tint short distance in front of player on some maps
Need for Speed:     Underground 1 & 2 and MW	Red & blue tint and/or flickering across screen
Okami	Red & blue tint, objects in background blacked out
Psi-Ops	Levels which would previously flicker between the normal output and a solid color now only show the solid color
Shining Force EXA	Characters and some objects blacked out
Sly 2 & 3	Stripes on textures
Wild Arms 3	Red and/or blue tint

[literalmente-game]

Wild Arms 3 is also affected. Some scenes have a red and/or blue tint which was not present on older builds (https://github.com/jpd002/Play-/commit/e584f5d6397bf052298e65de64f3d50c08ba6161) (https://github.com/jpd002/Play-/commit/e584f5d6397bf052298e65de64f3d50c08ba6161 was before the Yakuza branch merge).

[jpd002]

This is surely the commit that broke these games: https://github.com/jpd002/Play-/commit/61f4ca3d73e9d4452b48e1b40cace837cbd27f2f

The commit enables reading from a render target's alpha (PSMT8H is the upper 8 bits of a 32-bit pixel). My first guess would be that the problem is caused by reading a texture while it's being used as a render target, which worked ok on my laptop (Intel GPU), but might not be supported on other GPUs.

[boberto5888]

worked ok on my laptop (Intel GPU), but might not be supported on other GPUs.

literalmente and I have shown this issue on Nvidia GPUs. Jenci showed these issues in NFS:MW on his Xperia XZ2's Adreno 630 GPU.

[jpd002]

Nevermind what I said, Okami is broken on my Intel GPU:

[rcaridade145]

Not sure if useful but PCSX2 has an hack for Yakuza (recently changed so it caught my attention) https://github.com/PCSX2/pcsx2/commit/8219bcd1b44cc16493755ea6228977d22d9f4f8c

[jpd002]

Potential fix: https://github.com/jpd002/Play-/commit/5b3c42b94cc150e6da2fcc7fa3a22582f7260572

Don't know if this is going to fix all these issues, but I tested on Okami and the red hue is gone.

[boberto5888]

It fixes the hue/tint issues (apart from DBZ's which differed from the tint in the other games). The games whose issues were not fixed are listed below:

Game	Visual Issue (click text to reveal image)
DBZ Budokai Tenkaichi 2 & 3	Light blue tint short distance in front of player on some maps
Psi-Ops	Levels which would previously flicker between the normal output and a solid color now only show the solid color
Shining Force EXA	Characters and some objects blacked out
Sly 2 & 3	Stripes on textures