Patrick J.P. Culp

Results 60 comments of Patrick J.P. Culp

- Fixed missing region from chained configuration. - Removed the extraneous `else`'s.

- Removed extraneous clones and references. - Set default log level for `aws_config` and `aws_smithy` to `Warn`. - Improved error handling and logging.

- Brought back stronger-typed regions and `region_from_string()`. - Renamed `aws: AwsConfig` to `pubsys_aws_config: PubsysAwsConfig` to reduce confusion. - Kept `arch` as a stronger-type throughout. - Replaced **ImageState** `ensure` statement with...

- Changed credentials logic will run even if only a single role is specified. - Credential expirations can now be None. - Removed endpoints.

- Rewrote client.rs to return providers instead of credentials. - Removed returning unneccessary result-types (and their associated error contexts).

Suppressed noisy `[2022-09-22T20:01:26Z INFO tracing::span] assume_role;` log.

Hi @plaisted, thanks for reaching out. Do you still see the same behavior if endpoint is set to: ``` endpoint = [ "https://AWSACCOUNTID.dkr.ecr.us-east-1.amazonaws.com" ] ``` ?

Since pulling from `AWSACCOUNTID.dkr.ecr.us-east-1.amazonaws.com/example.external.com/image:TAG` is working, but the mirrored `registry.external.com` is not, I wonder if some ECR-specific logic is being skipped when the registry is parsed. Credentials may need to...

For now we're just going to bump to 0.18.0/0.48.0 in #197.

I think another benefit of jumping to F36 is openssl 3.0.x is the default.