binocular icon indicating copy to clipboard operation
binocular copied to clipboard

Windows support

Open hartontw opened this issue 2 years ago • 1 comments

Hi,

First of all, congrats for the addon.

I'm experiencing some issues to make it work on Windows.

The first issue is with the workspace path. As usual paths on Windows are causing troubles with spaces.

A lazy approach to "fix" it is editing binoculatTask.js functions to something like this:

this.searchFile = () => this.initBinocularTask(binocular-cli ${this.opt} -f ${vscode.workspace.workspaceFolders?.map(x => -p "${x.uri.fsPath}").join(" ") ?? ""});

Once this issue is avoid some other occurs with bat.

bat

I've read that it can be related to the --ansi parameter of bat. I think it can't be fixed or avoided without changing binocular-cli and the repo link is broken.

Thanks for your work.

hartontw avatar May 14 '23 14:05 hartontw

@hartontw Thank you for reporting.

The cli library was private, just changed it to public.

I'm currently on vacation, but recently got a Windows machine and I'll test this later this week.

jpcrs avatar May 14 '23 23:05 jpcrs