JP Cimalando

Results 462 comments of JP Cimalando

The current progress of JSFX - converted the ASM code to GAS syntax, and checked the objdump outputs to be 1:1, removing nasm as dependency - implemented the discovery; currently...

> wondering if this is better in a branch until 100% finalized, or already good enough to be placed in the main branch... > what are your thoughts on it?...

Verified the state of Jsusfx against Reaper, that's how it is: - [x] the state is in 2 parts, parameters ("sliders") and serialization - [x] maximum of 64 sliders which...

It can be confirmed from Reaper saves that the relative path serves as unique ID. As an example, the unique ID would be `analysis/loudness_meter` for the file `/opt/REAPER/InstallData/Effects/analysis/loudness_meter`. Does Carla...

> During plugin load the carla settings struct provides access to the paths to look for in plugins. And can the discovery have access to the search paths too? It...

Understood. Then should carla-discovery of jsfx get rid of `doInit` perhaps? I make this run the compilation, but success can't be guaranteed without the import path deduced properly.

> I would say we should avoid the compilation if possible, or is that required to fetch plugin info? It's not required at all, just a note for later work:...

- [x] Note: there appears to be a mistake in file `jsusfx.cpp` The following should be modified from `ifdef` to `ifndef`, to let scripts print their messages. `#ifdef EEL_STRING_STDOUT_WRITE` In...

- [x] Other: values don't parse correctly when `LC_NUMERIC != C` Test case is Reaper `guitar/phaser`, which fails to modulate anything, because of multiplier `0.5` parsed as `0`.

Yes, this source code is C though. I'll fix it. Culprit is here https://github.com/falkTX/Carla/blob/555caea8a0e3aa28c1c1d9df081403b3efeadbe9/source/modules/eel2/source/WDL/eel2/nseel-compiler.c#L5869