Joao P C Bertoldo

Results 37 comments of Joao P C Bertoldo

> > A) it looks like the val split in the current yaml config of efficientad is cheating : ) > > Yes you're right about that. Fixing this isn't...

I adressed A and C in https://github.com/openvinotoolkit/anomalib/pull/1376

Full logs below ``` tests/pre_merge/utils/callbacks/visualizer_callback/test_visualizer.py F [100%] ===================================================================================================== FAILURES ===================================================================================================== __________________________________________________________________________________________ test_add_images[segmentation] ___________________________________________________________________________________________ dataset = 'segmentation' @pytest.mark.parametrize("dataset", ["segmentation"]) def test_add_images(dataset): """Tests if tensorboard logs are generated.""" with tempfile.TemporaryDirectory() as dir_loc:...

> @jpcbertoldo I am trying to understand this. We currently support passing the model class to the feature extractor https://github.com/openvinotoolkit/anomalib/blob/main/tests/pre_merge/models/test_feature_extractor.py#L76. Is what you are trying to achieve different from this?...

It's that but there's an extra catch. I actually do `class_path: some/python/module.py::DummyModel` because there is an incompatibility between anomalib and the repo where i get the class from, so i...

@ashwinvaidya17 How much effort would it be? Just wondering. Another suggestion: as this will be corrected, maybe could we rename the classes in ``` anomalib/utils/metrics/aupr.py anomalib/utils/metrics/auroc.py ``` To something that...

> ... the version change also breaks the CLI and I didn't try to fix that. I was referring to this in the "how much effort". > I haven't investigated...