James Panther

Results 79 comments of James Panther

This is definitely a topic where I do not have relevant knowledge or experience to make a call on the best way forward. My only concern is that the codes...

I'm happy with the proposal to use `zh_Hans`, `zh_Hans_CN`, `zh_Hant`, `zh_Hant_TW` if that is the consensus here?

Looking at this in more detail now, I'm already confused due to my lack of understanding of the dialects involved. Is the plan then to duplicate `zh-CN` to both `zh-Hans`...

I'm happy to do simple move and replace, the part I'm confused about is what changes need to be made to distinguish between `zh-Hant` and `zh-Hant-TW` or can these both...

I guess what I'm proposing is, would this be sufficient? ie. making 2 copies of each of the existing translations... ``` zh-CN -> zh-Hans zh-CN -> zh-Hans-CN zh-TW -> zh-Hant...

I've started a PR for this and have made the changes above. Have a look and let me know if you think this is sufficient.

I think this is an interesting idea... although I wonder if the HTTP requests could be better avoided if this was included as an NPM package and copied across that...

I really like this script but I still feel like a lot of the logic could be done locally if the SVG was just a direct file copy from `node_modules/@fortawesome/free-brands-svg-icons/svgs/brands`....

Thanks for the update, I think this is now complete in terms of functionality. Are you happy with the current state of the PR?