vim-slime icon indicating copy to clipboard operation
vim-slime copied to clipboard

Published 20 hours ago • verified publisher icon jpalardy

When on Windows, check for cmd.exe

Open djha-skin opened this issue 10 months ago • 4 comments

Neovim + slime gets tripped up on Windows when using conemu as the target. Neovim sets the shell slightly different, and the quotes don't work the same.

This PR fixes the problem.

djha-skin avatar Mar 30 '24 05:03 djha-skin

hi @djhaskin987

Thanks for the PR, I added a few questions inline

jpalardy avatar Apr 01 '24 20:04 jpalardy

So, summary for this evening:

  • writefile worked, I added it.
  • In order to ensure I didn't mess up all the line endings in the repo while working on Windows I added a .gitattributes file.
  • Left the if/then around CMD and escaped args unchanged.

djha-skin avatar Apr 03 '24 00:04 djha-skin

I'm not sold on the .gitattributes file, let's remove it for now.

The rest looks good 👍

jpalardy avatar Apr 03 '24 02:04 jpalardy

OK, will do tonight :)

djha-skin avatar Apr 10 '24 15:04 djha-skin

Sorry I didn't remove the attributes file I forgot.

djha-skin avatar Apr 24 '24 03:04 djha-skin

don't worry about it 👍

I kept your commits in

jpalardy avatar Apr 24 '24 05:04 jpalardy