moodle-tool_mergeusers icon indicating copy to clipboard operation
moodle-tool_mergeusers copied to clipboard

MOODLE_INTERNAL check

Open OlenaTatarintseva opened this issue 4 years ago • 3 comments

Hello,

First of all I want say thank you for your work with the plugin.

I just would like to suggest, that it would be good to add MOODLE_INTERNAL check in php files in the plugin to comply Moodle code requirements: https://docs.moodle.org/dev/Coding_style#Require_.2F_include.

Files: admin/tool/mergeusers/select_form.php admin/tool/mergeusers/review_form.php admin/tool/mergeusers/index_form.php admin/tool/mergeusers/tests/clioptions_test.php admin/tool/mergeusers/tests/enrolments_test.php admin/tool/mergeusers/tests/quiz_test.php admin/tool/mergeusers/lib/merger.php admin/tool/mergeusers/lib/autoload.php admin/tool/mergeusers/db/upgrade.php admin/tool/mergeusers/db/events.php admin/tool/mergeusers/db/access.php

Best regards, Olena Tatarintseva

OlenaTatarintseva avatar Mar 11 '20 16:03 OlenaTatarintseva

Thanks for the comment and suggestion!

Could you proposo a PR with those changes, please? This would help to accelerate the completion of this issue!

All the best!

jpahullo avatar Mar 11 '20 17:03 jpahullo

It might be useful to note that the moodle_internal check policy is under discussion for a change here: https://tracker.moodle.org/browse/MDLSITE-5967

danmarsden avatar Mar 11 '20 18:03 danmarsden

Thanks @danmarsden !!! Right, we'll check it before making any further changes. Good to know! Thanks!!!

jpahullo avatar Mar 14 '20 11:03 jpahullo