moodle-tool_mergeusers
moodle-tool_mergeusers copied to clipboard
MOODLE_INTERNAL check
Hello,
First of all I want say thank you for your work with the plugin.
I just would like to suggest, that it would be good to add MOODLE_INTERNAL check in php files in the plugin to comply Moodle code requirements: https://docs.moodle.org/dev/Coding_style#Require_.2F_include.
Files: admin/tool/mergeusers/select_form.php admin/tool/mergeusers/review_form.php admin/tool/mergeusers/index_form.php admin/tool/mergeusers/tests/clioptions_test.php admin/tool/mergeusers/tests/enrolments_test.php admin/tool/mergeusers/tests/quiz_test.php admin/tool/mergeusers/lib/merger.php admin/tool/mergeusers/lib/autoload.php admin/tool/mergeusers/db/upgrade.php admin/tool/mergeusers/db/events.php admin/tool/mergeusers/db/access.php
Best regards, Olena Tatarintseva
Thanks for the comment and suggestion!
Could you proposo a PR with those changes, please? This would help to accelerate the completion of this issue!
All the best!
It might be useful to note that the moodle_internal check policy is under discussion for a change here: https://tracker.moodle.org/browse/MDLSITE-5967
Thanks @danmarsden !!! Right, we'll check it before making any further changes. Good to know! Thanks!!!