helm-openldap icon indicating copy to clipboard operation
helm-openldap copied to clipboard

Any reason why LDAP_BASE_DN is not setable via ENV

Open EugenMayer opened this issue 3 years ago • 2 comments

For me it was convinient to set the LDAP_BASE_DN via the ENV file, since the image supports it ( see https://github.com/EugenMayer/docker-rancher-extra-catalogs/blob/master/templates/openldap/26/docker-compose.yml#L14 )

Are there any particular reasons you do not support setting this out of the box, are there technical issues you are trying to avoid?

Great to have your insight / design decision here, thanks!

EugenMayer avatar Jan 04 '22 08:01 EugenMayer

Hi @EugenMayer

The chart is currenlty under a large refractoring to match best practices and be more user friendly to use. You can track/contribute under the branch https://github.com/jp-gouin/helm-openldap/tree/refractor-chart.

I hope to get some time soon to finish the work

jp-gouin avatar Jan 06 '22 12:01 jp-gouin

Hi @EugenMayer , You probably figure something else by the time but I’d still want to answer your question ☺️ from the osixia openldap documentation LDAP_DOMAIN: Ldap domain. Defaults to example.org LDAP_BASE_DN: Ldap base DN. If empty automatically set from LDAP_DOMAIN value. Defaults to (empty)

Both are possible but it’s true that I choose the LDAP_DOMAIN approach , a little bit more natural but that just my opinion. It will be complicated now that I’ve done the refactoring to use LDAP_BASE_DN because I use LDAP_DOMAIN variable in the helper to unit global variable used by sub charts .

what did you want to achieve and why LDAP_DOMAIN wasn’t an option for you ?

jp-gouin avatar Apr 22 '22 20:04 jp-gouin

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 14 '22 00:11 stale[bot]