helm-openldap
helm-openldap copied to clipboard
Allow to disable port on services.
What this PR does / why we need it:
When using service as load balancer, if we setup ldap to be on secure port only we don't want to expose the insecure port. Currently there is no way to do that.
With this modification, users can enable or disable exposition of insecure or secure port on the service.
Default values keep the current behaviour.
Pre-submission checklist:
- [X] Did you explain what problem does this PR solve? Or what new features have been added?
- [X] Have you updated the readme?
- [X] Is this PR backward compatible? If it is not backward compatible, please discuss open a ticket first
Can you add a test where you disable the ldap port and test the replication (writing a entry and reading it) ? You can check on existing tests
@jp-gouin Okay I think I manage to create tests
Is that okay for you ?