helm-openldap icon indicating copy to clipboard operation
helm-openldap copied to clipboard

fix: Allow IPv6 on ltb-passwd

Open SuperQ opened this issue 1 year ago • 10 comments

What this PR does / why we need it:

  • Listen on both IPv4 and IPv6 in the ltb-passwd to fix health probes on dual-stack clusters.
  • Include upstream chart env in main values.yaml.

https://github.com/tiredofit/docker-self-service-password/issues/66

Pre-submission checklist:

  • [x] Did you explain what problem does this PR solve? Or what new features have been added?
  • [ ] Have you updated the readme?
  • [x] Is this PR backward compatible? If it is not backward compatible, please discuss open a ticket first

SuperQ avatar Sep 30 '23 13:09 SuperQ

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 29 '23 20:11 stale[bot]

Not stale, just need review by @jp-gouin

SuperQ avatar Nov 29 '23 20:11 SuperQ

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 28 '24 20:01 stale[bot]

Still not stale

SuperQ avatar Jan 28 '24 21:01 SuperQ

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 29 '24 06:03 stale[bot]

Still waiting

SuperQ avatar Mar 29 '24 08:03 SuperQ

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 29 '24 03:05 stale[bot]

Still waiting

SuperQ avatar May 29 '24 03:05 SuperQ

Hi @SuperQ , I'm not sure your issue need a fix in the values as the chart already allows you specifying ltb-passwd.env

Maybe would make more sense to add the info in the readme ?

I know it's been a while , so feel free to close the PR and I'll include the variable in the readme in the next update

jp-gouin avatar Jun 07 '24 17:06 jp-gouin

I don't really mind how it is changed, but I think the defaults for this chart should work correctly with dual stack by default.

SuperQ avatar Jun 07 '24 17:06 SuperQ

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 06 '24 21:08 stale[bot]

Still would like to see this added

SuperQ avatar Aug 06 '24 21:08 SuperQ