Joy Reynolds

Results 369 comments of Joy Reynolds

Did you try timing the second time you do a `jj log` command? (Is the first one doing imports from Git for the whole repo or would that be done...

The `sys time`s of both are very similar. It's the `real time` that is inflated.

When I try it, I get > Warning: The argument "README" is being interpreted as a path. To specify a revset, pass -r "README" instead. Does that indicate a different...

I do not like the underlines. I prefer the background color change. I don't quite understand the coloring of the line numbers, though. What does it do when there is...

> Do you like the delta example here: [#3914 (comment)](https://github.com/martinvonz/jj/pull/3914#discussion_r1649825847) ? Yes, it looks good to me, but I think it would be difficult for the 7% that are colorblind,...

I vote yes for showing the author and if anything needs to be cut, omit the commit ID.

> I don't think post-commit hooks make a lot of sense. A post-commit hook can only really do validation In the context of a GUI, would it make sense that...

> we can just as easily make it a pre-upload hook. Does this refer to `jj git push` or is there another command that falls under this label? Does your...

> what you're trying to ask here is "can we make sure that pre-upload hooks are able to be run without actually pushing anywhere?". Actually, I was thinking more in...

> I only care that from the perspective of a user of jj, I can make sure that jj doesn't let me upload a bad commit. I know the `jj`...