Joyee Cheung

(I also take it that you do want to be able to inspect the loader thread...so you do want to leave `kNoCreateInspector` flag to zero. Otherwise, you'd need to somehow...

Thanks for the ping, not sure how I missed the earlier one. I diff'ed the generated snapshot locally and found ~20 lines of differences in the snapshot.cc generated (with `--predictable`,...

With this patch the snapshot.cc difference is down to 13 lines. Still need to figure out the differences in the blob though. see diff ```diff diff --git a/src/cleanup_queue-inl.h b/src/cleanup_queue-inl.h index...

Checking the snapshots again, another source of indeterminism comes from performance data (milestones, time origin etc.), the easiest way to fix it is probably discarding it before snapshot generation. But...

With https://github.com/nodejs/node/pull/48702 and https://github.com/nodejs/node/pull/48708 and --predictable the differences are down to 8 places: 1. 7 of which coming from binding data's embedder data slot 2. 1 of which coming from...

Thanks, I think when https://github.com/nodejs/node/pull/48851 lands, we could also add another flag to display the `node_snapshot.cc` in a more human readable way, then the CI can just diff the two...

I am adding a flag to make the diff output more readable (it would easier to calculate offsets of the differences in the data): https://github.com/nodejs/node/pull/49312

With the flag the diff output is currently ```diff 9c9 < static const char v8_snapshot_blob_data[] = {4,0,0,0,1,0,0,0,52,90,-119,-9,49,49,46,51,46,50,52,52,46,56,45,110,111,100,101,46,49,52,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, // 0 --- > static const char v8_snapshot_blob_data[] = {4,0,0,0,1,0,0,0,-125,90,-8,1,49,49,46,51,46,50,52,52,46,56,45,110,111,100,101,46,49,52,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, // 0 13318c13318...

FYI, just landed the --write-snapshot-as-array-literals flag to the configure script

With https://github.com/nodejs/node/pull/50983 locally I can generate reproducible snapshots, though the binary still differ