diaphora icon indicating copy to clipboard operation
diaphora copied to clipboard

confusion about function: find_matches_in_hole

Open xrkk opened this issue 4 years ago • 1 comments

as the name suggests, this function aims to find matches in hole range between 2 matched items. last indicates upper bound of the hole range. row indicates lower bound of the hole range. but, in the expression: cur.execute(sql, (id1+j, id2+i)), ida1+j and id2+i apparently below the lower bound of the hole range, which means, functions selected by this sql query are outside of the hole range. where am i wrong?

xrkk avatar Jul 07 '20 08:07 xrkk

I haven't looked at that code since I wrote it so, I'm sure there are a gazilion things wrong. I'm adding this to a (not so long) list of things to review and potentitally refactor. Thank you for pointing me to this!

joxeankoret avatar Jul 12 '20 09:07 joxeankoret

This is fixed in Diaphora 3.0, to be released soon. If you want to try to beta, tell me and I will send you it.

joxeankoret avatar Apr 10 '23 17:04 joxeankoret