librefprop.so icon indicating copy to clipboard operation
librefprop.so copied to clipboard

Consider deprecating this repo

Open ibell opened this issue 9 years ago • 6 comments

@jowr et al., I have (in my NIST capacity), developed a CMake-based workflow for building the REFPROP shared library reliably on windows/linux/OSX, with the nicest feature: all the functions are ALSO output with mixed case when compiling with gfortran. It is exceptionally easy to use the cmake workflow, and I would appreciate testing from folks.

The repo is here: https://github.com/usnistgov/REFPROP-cmake

ibell avatar Apr 01 '16 15:04 ibell

Very nice! I hope that NIST maintains the repo. What about MATLAB? It seems that most people that come here need REFPROP for MATLAB on either OSX or Linux.

jowr avatar Apr 04 '16 06:04 jowr

@ibell Glad to hear NIST is taking on this responsibility, but I wouldn't suggest deprecating it until it's a full replacement. At 18 days it's hardly 'proven'. This has been in use for years.

Rodbourn avatar Apr 04 '16 07:04 Rodbourn

@Rodbourn, I'd be happy to have you try out our cmake build system and report bugs. I think it should be quite a bit more reliable - that has been the experience thus far. But we'll only know once we get testers. I don't have plans to remove @jowr 's hard work, just offer a new alternative that should be useful to a lot of folks. You can also build with visual studio + Intel fortran.

On Mon, Apr 4, 2016 at 1:52 AM, Rodbourn [email protected] wrote:

@ibell https://github.com/ibell Glad to hear NIST is taking on this responsibility, but I wouldn't suggest deprecating it until it's a full replacement. At 18 days it's hardly 'proven'. This has been in use for years.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/jowr/librefprop.so/issues/39#issuecomment-205179271

ibell avatar Apr 04 '16 14:04 ibell

On a ubuntu 15.10 64 bits machine:

sudo apt-get install cmake gfortran
git clone https://github.com/usnistgov/REFPROP-cmake.git
cd REFPROP-cmake
git submodule init
git submodule update
cp -R <REFPROP fortran folder location> FORTRAN   # fortran folder needs to be uppercase
cd FORTRAN
for i in *.F; do mv -- "$i" "${i/%.F/.FOR}"; done   # fortran files are expected to have a .FOR extension
sed -i -e 's/      dll_export/c     dll_export/' PASS_FTN.FOR   # no DLL export for GNU/Linux
cd ..
mkdir build
cd build
cmake ..
cmake --build .

The simplest way to test the newly built libREFPRP64.so is to use the file testRP.m which requires MATLAB. As I have not the software on this computer, I'll test it next week, at work. I would like to test it using a simple FORTRAN code, is one of you have that at hand? @jowr or @ibell ?

ghost avatar Apr 20 '16 21:04 ghost

@ibell Thanks, we're looking forward to a smoother version of this install.

When I try to follow your instructions,

cmake ..
  ...
  CMake Error at CMakeLists.txt:86 (file):
    file COPY cannot find "[mydir]/REFPROP-cmake/gfortran: warning:
    couldn’t understand kern.osversion ‘15.5.0

Do you know whats going on here? Could be I'm making a simple mistake as I haven't used CMake before.

ericksonla avatar Jul 02 '16 22:07 ericksonla

Can you provide the complete build log?

On Sat, Jul 2, 2016 at 4:27 PM, Luke Erickson [email protected] wrote:

@ibell https://github.com/ibell Thanks, we're looking forward to a smoother version of this install.

When I try to follow your instructions,

cmake .. ... CMake Error at CMakeLists.txt:86 (file): file COPY cannot find "[mydir]/REFPROP-cmake/gfortran: warning: couldn’t understand kern.osversion ‘15.5.0

Do you know whats going on here? Could be I'm making a simple mistake as I haven't used CMake before.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jowr/librefprop.so/issues/39#issuecomment-230125019, or mute the thread https://github.com/notifications/unsubscribe/ABxhayekTfcaPkxBQc8kYnvxzKgxNkotks5qRuXMgaJpZM4H9zIW .

ibell avatar Jul 02 '16 23:07 ibell