librefprop.so icon indicating copy to clipboard operation
librefprop.so copied to clipboard

9.11 additional functions clash

Open ibell opened this issue 10 years ago • 5 comments

In version 9.11 of REFPROP, the additional functions that are included in src/PASS_FTN_ALT.f are no longer needed since they are provided in REFPROP itself. Not sure how best to fix this, but I "fixed" it by commenting out these functions in src/PASS_FTN_ALT.f. Fun times.

ibell avatar Aug 03 '15 00:08 ibell

Shouldn't we just rermove src/PASS_FTN_ALT.f from the sources?

jowr avatar Aug 12 '15 10:08 jowr

Yes that would probably do it, but only if the REFPROP version is >=9.11

On Wed, Aug 12, 2015 at 4:10 AM, Jorrit Wronski [email protected] wrote:

Shouldn't we just rermove src/PASS_FTN_ALT.f from the sources?

— Reply to this email directly or view it on GitHub https://github.com/jowr/librefprop.so/issues/31#issuecomment-130248370.

ibell avatar Aug 13 '15 05:08 ibell

Excluding it from the compilation process using the makefile would be better, I think, if the file is still distributed with REFPROP 9.11. Doing so, you don't delete it, and you don't need to comment the lines out.

ghost avatar Aug 14 '15 06:08 ghost

Oh, that is what I meant: Remove it from the list of files to compile - not deleting it.

jowr avatar Aug 14 '15 07:08 jowr

OK ! :-) ; Does somebody have a REFPROP 9.11 to test the code after the makefile has been modified? It seems that Ian has it. Do you also have a version at hand, Jorrit? Personally, I don't, but I can make the modification and make a pull request, as long as one of you test the code after that :-).

ghost avatar Aug 14 '15 07:08 ghost