starlette-admin icon indicating copy to clipboard operation
starlette-admin copied to clipboard

Support translation for delete row action submit button text.

Open hasansezertasan opened this issue 8 months ago • 4 comments

I didn't do anything with the i18n commands like compile or extract because those were removed at #425.

hasansezertasan avatar Dec 27 '23 13:12 hasansezertasan

because those were removed at https://github.com/jowilf/starlette-admin/pull/425.

They(Username and Password) had already been translated.

jowilf avatar Dec 31 '23 20:12 jowilf

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (63948e3) 100.00% compared to head (ba01a3e) 100.00%.

:exclamation: Current head ba01a3e differs from pull request most recent head e419d09. Consider uploading reports for the commit e419d09 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #441   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           75        75           
  Lines         5812      5767   -45     
=========================================
- Hits          5812      5767   -45     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 31 '23 20:12 codecov[bot]

OK then I'll compile it and commit.

hasansezertasan avatar Dec 31 '23 21:12 hasansezertasan

@jowilf It should be ready now. I have removed "fuzzy" translations and I didn't add any translations for Turkish.

hasansezertasan avatar Jan 02 '24 19:01 hasansezertasan

Closing due to inactivity.

hasansezertasan avatar May 06 '24 16:05 hasansezertasan