starlette-admin icon indicating copy to clipboard operation
starlette-admin copied to clipboard

Enhancement: Tabler Theme: Light and Dark Mode

Open hasansezertasan opened this issue 10 months ago • 4 comments

Is your feature request related to a problem? Please describe. Like some developers, I also feel like "dark mode" rules and light mode hurts...

Describe the solution you'd like Tabler offers great features like switching themes. Why wouldn't we integrate this one to the Starlette Admin?

Additional context I found this article on medium. I opened Starlette Admin Demo and checked out the console, tried to switch theme. It was easy but It doesn't work on some of the fields.

hasansezertasan avatar Nov 04 '23 07:11 hasansezertasan

I searched a bit and found this issue on the tabler repo.

I added data-bs-theme="dark" attribute to various body tags in the starlette-admin-demo.jowilf.com/admin/sqla/ page.

These are the results:

Home

image

Users List Page

image

Users Detail Page

image

Users Create Page

image

We should make all the pages compatible with this feature before implementing it.

hasansezertasan avatar Jan 04 '24 00:01 hasansezertasan

I've done some progress on this feature but dark mode brakes Select2 based fields.

hasansezertasan avatar May 08 '24 23:05 hasansezertasan

I think we can add ui tag here. WDYT @jowilf?

hasansezertasan avatar May 08 '24 23:05 hasansezertasan

Hi @hasansezertasan, I had a similar issue with select2 when when I was trying to integrate validation errors. I was able to fix it using this css code. Perhaps, you could try using a similar approach?

jowilf avatar May 10 '24 22:05 jowilf