starlette-admin icon indicating copy to clipboard operation
starlette-admin copied to clipboard

Published 20 hours ago • verified publisher icon jowilf

add beanie support

Open opaniagu opened this issue 1 year ago • 9 comments

I share this PR to be able to support 'beanie' https://beanie-odm.dev/. Please send feedback and help me test. Also, GridFs is supported.

opaniagu avatar May 09 '23 16:05 opaniagu

Thank you for submitting the PR! I appreciate your effort and initiative.

I'll do my best to review your changes as soon as possible. In the meantime, you can refer to the test cases for 'odmantic' and 'mongoengine' for testing guidance.

With a quick look, I noticed some comments are in Spanish. To ensure clarity for everyone, it would be better to have them in English. Could you please update those comments?

jowilf avatar May 12 '23 03:05 jowilf

Would love to see this getting merged. Any update on this?

martincpt avatar Aug 14 '23 21:08 martincpt

Hello @opaniagu , Are you still planning to address the review comments? If there's anything I can do to help move it forward, please let me know.

jowilf avatar Aug 19 '23 19:08 jowilf

Hello @opaniagu , Are you still planning to address the review comments? If there's anything I can do to help move it forward, please let me know.

Hello, I have little time at the moment. The main problem is that for me (I think) it is already a functional version, but when I was finishing you changed the core and it means I have to review everything from scratch.

opaniagu avatar Aug 21 '23 13:08 opaniagu

Hello, I have little time at the moment. The main problem is that for me (I think) it is already a functional version, but when I was finishing you changed the core and it means I have to review everything from scratch.

I truly appreciate your effort, and I'm sorry if the changes inadvertently affected your work. The intention was to improve the conversion process and provide customization options.

jowilf avatar Aug 30 '23 22:08 jowilf

@opaniagu Any update on this?

This PR fix and merge could really help alot.

ayyshim avatar Sep 15 '23 18:09 ayyshim

Hey @opaniagu, I'd like to see this PR to be merged but as far as I can see, the core is outdated. Do you plan to work on this?

hasansezertasan avatar Jan 02 '24 19:01 hasansezertasan

Hey @opaniagu, I'd like to see this PR to be merged but as far as I can see, the core is outdated. Do you plan to work on this?

Hi, really now I haven´t time to continue, maybe someone can take it, and finisih.

opaniagu avatar Jan 03 '24 01:01 opaniagu

I see, thank you for trying it out 🙏. It might give people some idea. I'm going to play with Beanie in the future. It might be useful.

hasansezertasan avatar Jan 03 '24 01:01 hasansezertasan