Jo-Philipp Wich
Jo-Philipp Wich
Well, I don't think it will get fixed, afair it only affects multi-switch swconfig devices, devices with a single switch are unaffected and swconfig in general is deprecated and will...
Cannot reproduce it in the chrome mobile device emulation and can't test on real hardware since I don't own any Android device. Maybe someone else can confirm/debug
If you hover the red select box, is any error description shown in the red tooltip? Is the select box colored red after hitting any button or automatically? Does it...
What exact problem is this PR fixing? Maybe include a short description in the commit message. Apart from that lgtm.
The object registry will still be needed though, just not for tracking internal pointers anymore. But suppose you do something like `ubus.defer(…)` or `uloop.handle(…)` without storing the return value in...
I see the need but conceptually I am not happy with exposing gc details like that. Need to think some more about it, but my gut feeling so far is...
Seems I failed to actually submit my drafted review - sorry. This already looks quite good - but I would really love to eliminate either of the `data` or `uvcount`...
Perfect. I just took a quick glance and the only in-tree library that touches `->data` directly is the debug one, it needs some slight extensions to properly decode extended headers;...
Ah, anonymous unions. I always avoided them due to their proprietary nature but given that we use many other extensions already this makes a lot of sense and simplifies things....
Almost golden. My remaining pet peeve is the naming schema deviation in `ucv_resource_get_no_gc()` and `ucv_resource_set_no_gc()`. I would propose these alternatives names: - `ucv_resource_retained_get()` / `ucv_resource_retained_set()` [as in kept around on...