Jo-Philipp Wich

Results 295 comments of Jo-Philipp Wich

Upstream forcibly enables SSL support in nginx, there's no way to provide non-ssl variants of it anymore.

Not sure we really want to flush the menu *on every single* uci change. The menu depends mechanism was not really meant for that level of dynamic usage. Primary use...

I added a pull request to include syntax highlighting in OpenWrt's nano package: https://github.com/openwrt/packages/pull/22623

@eric-j-ason - I suggest to use the nano highlighting I submitted in the other PR as authoritative source for the supported syntax keywords. See also https://github.com/jow-/ucode/blob/master/lexer.c#L47 There's some special cases...

I don’t think the luci-proto-bonding package will receive fixes to support non-static config, it should rather become deprecated in favor to bonding device config support which is present in netifd...

> For example, would opkg consider 1.1.1-r6 higher version than 1.1.1-5? Same question for 2023.11.19-r2 and 2023-11-19-1. ``` root@OpenWrt:~# opkg compare-versions 1.1.1-r6 '>' 1.1.1-5 && echo true || echo false...

For now I tend towards living with the code duplication since factoring out the shared bits into a shared library would complicate things. Maybe the boilerplate parts can be extracted...

It's a bug in the JSON output produced by https://github.com/openwrt/routing/blob/master/babeld/src/ubus.c - note the duplicate dictionary key `fe80::2923` - we can't fix this on the LuCI side.

> We could change it to [IP]%[DEV] to fix duplicate addressing Sounds sensible to me! Just make sure to only do that for `fe80...` link local addresses, others are guaranteed...