Jovan Stojanovic

Results 27 comments of Jovan Stojanovic
trafficstars

The changelog test apparently works fine :) You should add the PR number to CHANGES.rst

Merging! Thanks @LeoGrin

Merging https://github.com/dirty-cat/dirty_cat/pull/439 may resolve some functions.

Thanks! Interesting use case but there is something I don't understand: > So I already create a table of unique values and their counts and then use this as input...

I see, then best to do in my opinion is the following: - finish this version of deduplication; - add an issue mentioning this, to keep track of it and...

Hey @mjboos, we are ready for a beta release, would be good to have this as well. Do you need assistance with the few changes left?

The test_docstrings.py are failing (you should update the docstrings to meet the numpydoc standards).

It's green, merging. Thanks!

Thanks @LeoGrin, great suggestion. As a matter of fact, I think this is a very common use case. I think you are right that ID columns should be treated differently,...