inline-chunk-manifest-html-webpack-plugin
inline-chunk-manifest-html-webpack-plugin copied to clipboard
Add `inject` option
Supports:
-
false
(as documented) -
"body"
(append to body of template) -
"head"
(append to head: default + original)
Thank you for the PR 🥇
A couple of comments:
- The
inject
option you're referring to as documented is actually forhtml-webpack-plugin
.
- See this issue https://github.com/jouni-kantola/inline-chunk-manifest-html-webpack-plugin/issues/3
- The following section in the readme: https://github.com/jouni-kantola/inline-chunk-manifest-html-webpack-plugin/blob/master/README.md#explicit-inject
By using
inject: false
withhtml-webpack-plugin
you can already inject the chunk manifest where you need it (i.e.body
). With this in mind, do you still think this extrainject
is a good configuration option? Let's discuss that for a bit.
After we decide if we should add this option or not, then I'd appreciate tests and docs for it.
-
Tests fits around here: https://github.com/jouni-kantola/inline-chunk-manifest-html-webpack-plugin/blob/master/test/plugin-inject-manifest-test.js#L4
-
The last bit that I think is missing is docs for the new configuration property. It probably needs extra clarity in this case, since there already is a similar configuration option for
html-webpack-plugin
.