joule-extension icon indicating copy to clipboard operation
joule-extension copied to clipboard

Published 20 hours ago • verified publisher icon joule-labs

Do not recreate the address each time as I would like to double check before sending funds

Open marsrobertson opened this issue 5 years ago • 2 comments

  1. I want to deposit into Joule
  2. The BTC address is shown
  3. Copy the address
  4. Go to my other wallet to send $20 as suggested here
  5. Double check the address
  6. 🤔

Suggested solution

image

marsrobertson avatar May 28 '19 19:05 marsrobertson

This totally makes sense, but is unfortunately the default behavior of LND to generate a new one on each request. Might make sense to keep a local cache, though I worry that this might unintentionally lead to address reuse. If there are suggestions on how to improve it and account for both cases, I'm all ears.

wbobeirne avatar May 28 '19 20:05 wbobeirne

Totally aware that address reuse is not OK and should not be encouraged.

Thinking about workarounds, caching, heuristics (keep it for 30 minutes unless incoming transaction) but I'm worried it will add work and complexity at a cost of even more confusion.

Now at least it is consistent - new address each time.

marsrobertson avatar May 29 '19 10:05 marsrobertson