osmium icon indicating copy to clipboard operation
osmium copied to clipboard

Endless loop in MultiPolygon::Builder::complete_ring for relation 1187332

Open skaringa opened this issue 10 years ago • 1 comments

I run the command osmjs -2 -m -l sparsetable -i osm2shape.js -j config.js poland.osm.pbf where poland.osm.pbf was downloaded today Sept 4th 2013 from geofabrik.de

The program "never" completes. (At least not within one hour - last week it took only some minutes at my machine). Further investigations show that the program never finishes the method complete_ring in class Osmium::MultiPolygon::Builder during processing the relation 1187332 which is a boundary somewhere in Poland. I see that complete_ring calls itself around 200-230 times recursively and is then looping endlessly.

Since I don't understand the code in MultiPolygon::Builder really any help is welcome. Thank you in advance!

skaringa avatar Sep 04 '13 12:09 skaringa

The relation isn't a multipolygon, it doesn't describe a boundary, but it seems to be a collection of roads. It should never have been tagged as type=boundary. You can look at it here: http://www.openstreetmap.org/browse/relation/1187332 .

That being said, Osmium should not just hang working on it but do something useful or emit an error message. So this is a definite Osmium bug.

joto avatar Sep 18 '13 13:09 joto