Results 114 issues of Jochen Topf

Profiling shows that the `sparse_mmap_array` node location store is faster than others for small and medium datasets, but it still takes a huge amount of processing time. This is probably...

enhancement

Current code assembles multipolygons in the same way regardless of whether they are created from a closed way or from a multipolygon relation. This might be wasteful. Chances are the...

enhancement

File formats (XML, PBF, ...) are currently detected based on file name suffixes. Additionally or instead we could detect formats by looking at the first few bytes of the file.

enhancement

The classes in osmium::index::map/multimap are just simple wrapper classes for different data structures. Most of their functions are really simple and good candidates for inlining. This would work if thoses...

enhancement
question

Building/Testing `tools/pbf-decoder` is disabled on Windows because of the missing getopt library. We should figure something out here. See also https://github.com/mapbox/vtzero/issues/20.

`pbf_reader::get_packed_bool()` currently calls `get_packed_int32()`. But with a one-byte bool there will never be any endianness or alignment issues so we could optimize this case.

enhancement

See for instance https://travis-ci.org/mapbox/variant/jobs/188957587 . You have to expand the "after_script" to see this. The job itself doesn't fail, though. Protozero has the same problem with Python, but in that...

Our implementation of variant allows access via `get()` even if the type appears several times in the variant. This can be potentially confusing and error prone, especially when type aliasing...

question

In the current code there is no implementation for `swap()` which means `std::swap()` will be used. This should do the right thing (as long as the move constructor and move...

enhancement

I think the `noexcept` on `operator()` [here](https://github.com/mapbox/variant/blob/c4e864cc122c4fcc9b1f7a8f68a34e465df9f922/variant.hpp#L644) is wrong. There are several operations involved which all might fail.