jtbin icon indicating copy to clipboard operation
jtbin copied to clipboard

Update Ghouls'n Ghosts MRA DIP switches

Open Abadede opened this issue 1 year ago • 2 comments

  • Fixed missing ids, unnecessary commas and verbosity to fit menu and make options work properly
  • Added missing Demo Sound switch
  • Added daimakair level select switches
  • Moved ghoulsu test switches under Test Mode
  • Tried to match game manuals terms instead of Mame menu when possible

Abadede avatar Aug 21 '22 10:08 Abadede

Thank you. Could you avoid the use of the values attribute in the DIP switches? It is not compatible with non MiSTer platforms and it doesn't seem to be needed here (you're just changing the order).

Could you also avoid changing lines for cosmetic reasons that are not related to the DIP switches? Like removing or adding spaces in the ROM lines. It makes the git history easier to trace when changes are kept to the point.

Thank you :-)

jotego avatar Aug 21 '22 16:08 jotego

Too bad about the values attributes, I thought mra files were for Mister use only. Anyway I think I made changes the way you wanted.

Abadede avatar Aug 22 '22 14:08 Abadede