jotaen4tinypilot

Results 50 comments of jotaen4tinypilot

tldr, I’m not sure we can find a way to maintain our current toggle button implementation and use [Playwright’s `getByLabel` locator](https://playwright.dev/docs/api/class-locator#locator-get-by-label). ## Background Our current toggle button implementation is based...

Yeah, I feel the same. Shall we remove it from 2.6.2 for now?

As discussed in the dev meeting, I went through our issues to find ones with big surface area. This one isn’t particularly small, unfortunately, but I think it would be...

Adding some thoughts here, just as I happened to stumble across this: Did the customer mention what exactly they found confusing? I.e., weren’t they familiar with the concept of bit...

The issue also seems to be a bit random/erratic, see https://github.com/tiny-pilot/tinypilot/pull/1583#pullrequestreview-1591862867. Maybe the resize event handler doesn’t fire reliably or so?

Another potential approach that I stumbled across is to divide the tests into different [test projects](https://playwright.dev/docs/test-projects), where each project can have its own configuration. I’m not sure, however, what the...

Update: [libwebsocket’s git server](https://libwebsockets.org/git/) is up again, so our e2e tests have recovered for the time being.

Re the idea of isolating the `app.db` module and providing our own, Flask-less CLI entry point: Out of curiosity, I ran a [quick-and-dirty POC on this branch](https://github.com/tiny-pilot/tinypilot-pro/compare/poc/cli-direct?expand=1). With this, you...

I just stumbled across this by accident: in the Janus config, there seems to be a setting [`ignore_unreachable_ice_server`](https://github.com/meetecho/janus-gateway/blob/ae23fb0f47ca3207cdd74b78d54212c08a402171/conf/janus.jcfg.sample.in#L391-L399). This setting was added to Janus via https://github.com/meetecho/janus-gateway/pull/1854. Unfortunately, that PR/fix wasn’t...

(Removed this from the 2.5.4 project for now, since we can’t add an indicator without being able [to detect audio capability](https://github.com/tiny-pilot/tinypilot/issues/1276).)