ra-data-feathers icon indicating copy to clipboard operation
ra-data-feathers copied to clipboard

Broken `peerDependencies` (`react-admin` `v2.x`)

Open strarsis opened this issue 1 year ago • 1 comments

react-admin is a peer dependency of this package, but for version ^2.1.1: https://github.com/josx/ra-data-feathers/blob/master/package.json#L49 This is totally broken, as react-admin v4 is the latest stable now, and before there was react-admin v3.

strarsis avatar Jul 17 '22 21:07 strarsis

Can you make a PR?

We can put on peerDeps something like supporting 2,3,4 react-admin versions, like

react-admin": "^2.1.1 || ^3.0.0 || ^4.0.0"

BTW npm show react-admin versions

[
'0.0.1',                '0.0.2',         '0.0.3',
'0.0.5',                '0.0.6',         '2.0.0-RC1',
'2.0.0-RC2',            '2.0.0-RC3',     '2.0.0-RC4',
'2.0.0-alpha1',         '2.0.0-alpha2',  '2.0.0-alpha3',
'2.0.0-beta1',          '2.0.0-beta2',   '2.0.0-beta3',
'2.0.0-beta4',          '2.0.0',         '2.0.2',
'2.0.3',                '2.0.4',         '2.1.0',
'2.1.1',                '2.1.2',         '2.1.3',
'2.1.4',                '2.1.5',         '2.2.0',
'2.2.1',                '2.2.2',         '2.2.3',
'2.2.4',                '2.3.0',         '2.3.1',
'2.3.2',                '2.3.3',         '2.3.4',
'2.4.0-0',              '2.4.0',         '2.4.1',
'2.4.2',                '2.4.3',         '2.4.4',
'2.5.0',                '2.5.1',         '2.5.2',
'2.5.3',                '2.6.0',         '2.6.1',
'2.6.2',                '2.6.3',         '2.6.4',
'2.7.0',                '2.7.1',         '2.7.2',
'2.7.3',                '2.8.0',         '2.8.1',
'2.8.2',                '2.8.3',         '2.8.4',
'2.8.5',                '2.8.6',         '2.9.0',
'2.9.1',                '2.9.2',         '2.9.3',
'2.9.4',                '2.9.5',         '2.9.6',
'2.9.7',                '2.9.8',         '2.9.9',
'3.0.0-alpha.0',        '3.0.0-alpha.1', '3.0.0-alpha.2',
'3.0.0-alpha.3',        '3.0.0-alpha.4', '3.0.0-beta.0',
'3.0.0-beta.2',         '3.0.0-beta.3',  '3.0.0-beta.4',
'3.0.0-beta.5',         '3.0.0-beta.6',  '3.0.0',
'3.0.1',                '3.0.2',         '3.0.3',
'3.0.4',                '3.1.0',         '3.1.1',
'3.1.2',                '3.1.3',         '3.1.4',
'3.2.0',                '3.2.1',         '3.2.2',
'3.2.3',                '3.2.4',         '3.3.0',
'3.3.1',                '3.3.2',         '3.3.3',
'3.3.4',                '3.4.0',         '3.4.1',
'3.4.2',                '3.4.3',         '3.4.4',
'3.5.0',                '3.5.1',         '3.5.2',
'3.5.3',                '3.5.5',         '3.5.6',
'3.6.0',                '3.6.1',         '3.6.2',
'3.6.3',                '3.7.0',         '3.7.1',
'3.7.2',                '3.8.0',         '3.8.1',
'3.8.2',                '3.8.3',         '3.8.4',
'3.8.5',                '3.9.0-beta.1',  '3.9.0-beta.2',
'3.9.0-beta.3',         '3.9.0',         '3.9.1',
'3.9.2',                '3.9.3',         '3.9.4',
'3.9.5',                '3.9.6',         '3.10.0',
'3.10.1',               '3.10.2',        '3.10.3',
'3.10.4',               '3.11.0',        '3.11.1',
'3.11.2',               '3.11.3',        '3.11.4',
'3.12.0',               '3.12.1',        '3.12.2',
'3.12.3',               '3.12.4',        '3.12.5',
'3.13.0',               '3.13.1',        '3.13.2',
'3.13.3',               '3.13.4',        '3.13.5',
'3.14.0',               '3.14.1',        '3.14.2',
'3.14.3',               '3.14.4',        '3.14.5',
'3.15.0',               '3.15.1',        '3.15.2',
'3.16.0',               '3.16.1',        '3.16.2',
'3.16.3',               '3.16.4',        '3.16.5',
'3.16.6',               '3.17.0',        '3.17.1',
'3.17.2',               '3.17.3',        '3.18.0',
'3.18.1',               '3.18.2',        '3.18.3',
'3.19.0',               '3.19.1',        '3.19.2',
'3.19.3',               '3.19.4',        '3.19.5',
'3.19.6',               '3.19.7',        '3.19.8',
'3.19.9',               '3.19.10',       '3.19.11',
'4.0.0-4.0.0-beta.1.0', '4.0.0-RC.0',    '4.0.0-RC.1',
'4.0.0-alpha.0',        '4.0.0-alpha.1', '4.0.0-alpha.2',
'4.0.0-beta.1.0',       '4.0.0-beta.2',  '4.0.0-beta.3',
'4.0.0-rc.0',           '4.0.0-rc.1',    '4.0.0',
'4.0.1',                '4.0.2',         '4.0.3',
'4.0.4',                '4.0.5',         '4.1.0',
'4.1.1',                '4.1.2',         '4.1.3',
'4.1.4',                '4.1.5',         '4.1.6',
'4.2.0',                '4.2.1',         '4.2.2',
'4.2.3'
]

josx avatar Jul 18 '22 17:07 josx

@grigoryo: Could you create a PR for this in this repo? I just ran into this exact issue again.

strarsis avatar May 11 '23 23:05 strarsis

As a workaround, this can be used in the project package.json:

    "overrides":{
        "react-admin": "^3.19.10"
    },

Due to an issue with npm, both, package-lock.json and node_modules/ have to be removed, before npm install uses the override.

strarsis avatar May 11 '23 23:05 strarsis