Jostein Kjønigsen

Results 625 comments of Jostein Kjønigsen

I've looked into this some more, and this code contains elements from both PR #110 and #119, but as far as I can see, the error was already there in...

Looking futher into this test-case it only seems to fail when the generic type-argument contains an array. Consider the following examples: ````typescript goodTestCase(boo: hoo, zoo:doo ) { } badTestCase(boo: hoo,...

After I merged #129 to git `master`, I'm able to make this look "good" with the following patch: ````diff @@ -1994,8 +1994,8 @@ This performs fontification according to `typescript--class-styles'." ;;...

Update: While my above patch solves the simple test-cases of goodTestCase and badTestCase, it doesnt work for more complex scenarios: ![image](https://user-images.githubusercontent.com/411338/76197188-fa229280-61eb-11ea-84e3-223cc26dc5a0.png) Now it's just weird. I'll leave it at this...

Making more things configurable just gives us a bigger state-space which we will need to manage and handle. And there in lies bugs. I say make it format things like...

> I posit that it should indent like this As far as Typescript goes, there's just *one* canonical answer to how things should be: However `tsserver` formats it. And lucky...

In csharp-mode we are experimenting on a complete rewrite based on tree-sitter-mode, which gives us a real AST to work with. The results there have been very promising. If we...

> @josteink from what I understand tree-sitter only supports highlighting? does it support other functions like mark-sexp, end-of-defun etc? which is more related to movement. I actually want to use...

So... We're rewriting `typescript-mode` to be `tree-sitter-mode` based too now? :grin: If so, I would suggest taking a look at [`csharp-tree-sitter-mode`](https://github.com/emacs-csharp/csharp-mode/blob/master/csharp-tree-sitter.el) as a whole, and start from scratch based on...

> The highlighter fails to handle anything in ${} as an expression I'm going to just assume that however we decide to handle this, it ultimately comes down to syntax-tables...