open-accessibility icon indicating copy to clipboard operation
open-accessibility copied to clipboard

safari > 11 QuotaExceededError error in private mode

Open boynet opened this issue 7 years ago • 2 comments

the error is raised when using localStorage in safari private mode in version prior to 11, the solution is pretty easy wrap localStorage call in setUserOptions() with try catch:

you can read more about it here https://stackoverflow.com/questions/21159301/quotaexceedederror-dom-exception-22-an-attempt-was-made-to-add-something-to-st

boynet avatar Mar 15 '18 13:03 boynet

Thanks for the report!

would you please make a Pull Request with a fix?

jossef avatar Mar 22 '18 15:03 jossef

I can but I made another change in my fork let me know what you think: the problem is in applyTextZoom() this function run even if the user never changes any accessibility option, and it really messed up the performance on site its not a good idea to mess with the dom when not needed, I made a quick hack but I can make a pretty fix it, to only run if zoom is changed or is not 1

boynet avatar May 03 '18 10:05 boynet