josie

reACK https://github.com/bitcoin/bitcoin/pull/26008/commits/a96647308ea40028806e2db6d35fb5dd14bea15f

ACK https://github.com/bitcoin/bitcoin/pull/26008/commits/ac246f68299d0dc208ae513dfad1a8fc91b5e6d4

ACK https://github.com/bitcoin/bitcoin/pull/21995/commits/54b4b16b8c83e9b9abe6e3853044ebacb8b59faa nicely done! I verified the symlink issue is fixed by running: ```bash # run 1 make -C depends make distclean # run 2 make -C depends ``` run...

I'd also prefer we stopped using `AvailableCoins` as a general wallet traversal tool in favor of something like https://github.com/bitcoin/bitcoin/pull/27286 A lot of bugs/strangeness in the wallet seems to come from...

> Hopefully this is helpful and not annoying, but here's a branch that makes the first couple commits less assert-happy and applies some of the suggestions to miniminer: https://github.com/glozow/bitcoin/tree/26152-fixups lgtm!

Two thoughts: 1) I think this could be split up into two PRs; one for `MiniMiner` and another for the wallet logic. My reasoning here is the MiniMiner code seems...

> But maybe this is a good reason _to_ remove it! If it never executes because of how our wallet operates, and the wallet is the only client of this...

Concept ACK Starting to review, if you get a chance can you rebase this so that it's only the relevant outstanding commits?

ACK https://github.com/bitcoin/bitcoin/pull/28574/commits/868e2f64a9d7de3a980e64fd7acd7323214d3765 Code reviewed and verified the bench results. Thanks for taking the suggestions!

 https://cirrus-ci.com/task/5752995407724544