samsung-galaxybook-extras
samsung-galaxybook-extras copied to clipboard
Integration with the desktop power managers
First of all, great job. I tested this on a 950XEE and it works just as advertised (after adding it to the HWDB pattern)
using kbdillumtoggle
The keyboard backlight is picked up automatically by UPower. Setting the kbd brightness by sending dbus messages as described in the arch wiki and has the advantage of not requiring root privileges.
Now the issue is how to get the power manager to recognize the key. I don't think prog2
is the best choice. Browsing the HWDB I see three values related to kbd backlight, which correspond to xf86 keysim values:
- kbdillumup: XF86XK_KbdBrightnessUp
- kbdillumdown: XF86XK_KbdBrightnessDown
- kbdillumtoggle: XF86XK_KbdLightOnOff
I'm using xfce4-power-manager and it recognizes "up" and "down" keys and I just made a patch for it to recognize the "toggle" key. I don't know whether other desktop environments handle the keys as well.
Performance mode
I took a look at power-profiles-daemon and TLP and they both use platform_profile to set the performance mode. If this driver were to use that interface it would work out of the box. I have no experience with kernel hacking, but I could give it a try.