Joshua Newton

Results 125 issues of Joshua Newton

Currently, we're only uploading coverage results for `Ubuntu 20.04`. This covers probably 95% of cases, but it would be nice to see what coverage is like for macOS and Windows,...

CI
OS: Windows (native)

> NB: This is a very minor, nitpicky quality-of-life suggestion for devs, so it's not _that_ high-priority, but... 1. Currently, all of our CLI tests include `"_cli_"` in their filenames:...

enhancement
tests
priority:LOW

_Originally posted by @kousu in https://github.com/spinalcordtoolbox/spinalcordtoolbox/pull/3373#discussion_r651219400_ > In the future, it would be good to make a `test_data` fixture that does > > ```suggestion > def test_sct_analyze_texture_image_data_within_threshold(test_data): > """Run the...

tests
refactoring
SCT API: utils.py

In PR https://github.com/spinalcordtoolbox/spinalcordtoolbox/pull/3591, we started experiencing some strange behavior for the [`test-batch-processing.yml`](https://github.com/spinalcordtoolbox/spinalcordtoolbox/actions/workflows/test-batch-processing.yml) workflow: * On one run, registration results would be different than expected, causing metric tests to fail. *...

bug
sct_register_to_template
upstream
API: registration

Context here: https://forum.spinalcordmri.org/t/sct-run-batch-include-list/770/3?u=joshuacwnewton > It seems that `include_list` required `ses` for longitudinal studies. On the other hand, `include` accepts both variants (with ses: `"include" : "sub-0001/ses-01"` and also without ses:...

bug
sct_run_batch
user requested

Currently, we maintain two different shell scripts and two different datasets: 1. [`batch_processing.sh`](https://github.com/spinalcordtoolbox/spinalcordtoolbox/blob/master/batch_processing.sh): This is the main script we use to [show off pipelines](https://spinalcordtoolbox.com/en/latest/user_section/getting-started.html#batch-processing-example) for typical SCT usage. - (Uses...

refactoring
script: batch_processing.sh

Currently, users download stable releases via the "Source code" links on the [Releases](https://github.com/spinalcordtoolbox/spinalcordtoolbox/releases) page (which point to a tag on the `release` branch). ![Screenshot from 2021-10-19 13-16-43](https://user-images.githubusercontent.com/16181459/137959666-d6f9c754-d4b4-44b0-b60b-24ffb92b70fb.png) The problem is:...

installation

This issue is a follow-up to an idea from #3633: > ### Bonus changes > We could also take this opportunity to output CSV instead of XSL, and PKL Related...

feature
sct_analyze_lesion

Idea suggested by SCT Course participants who are currently having difficulty with the existing installation steps.

documentation

While writing a test for #3560, I noticed that the centerline was missing from slices. So, I tried the full `t2s.nii.gz` image from `sct_example_data`, and encountered the same behavior: sct_testing_data:...

bug
API: reports