blueprint-css icon indicating copy to clipboard operation
blueprint-css copied to clipboard

Small tweaks to compress.rb (optional PNG grid flag, fixed semantic classes for ruby 1.9+)

Open nemoDreamer opened this issue 11 years ago • 6 comments

ChunkyPNG seems to be flaky on a lot of peoples dev environments, so i made it optional w/ the -g flag. Semantic Classes was using Array's implicit .to_s, which causes a ["...", "..."] output in newer versions of Ruby.

nemoDreamer avatar Sep 13 '13 20:09 nemoDreamer

@nemoDreamer It looks like the build is failing - mind getting this working so I can merge?

joshuaclayton avatar Nov 08 '13 20:11 joshuaclayton

Will do! Thanks for considering it ;)

On Fri, Nov 8, 2013 at 3:01 PM, Joshua Clayton [email protected]:

@nemoDreamer https://github.com/nemoDreamer It looks like the build is failing - mind getting this working so I can merge?

— Reply to this email directly or view it on GitHubhttps://github.com/joshuaclayton/blueprint-css/pull/20#issuecomment-28093299 .

nemoDreamer avatar Nov 10 '13 18:11 nemoDreamer

Travis seems to be failing on:

$ bundle install --deployment
Fetching gem metadata from http://rubygems.org/.........
Fetching gem metadata from http://rubygems.org/..
Could not find ffi-1.0.8 in any of the sources

ffi is a chunky_png dependency which seems to have had problems around the time I submitted this pull request. I switched to oily_png, as that is generally a good thing to do if you want more platforms to be able to compress.rb their own source.

nemoDreamer avatar Apr 10 '14 17:04 nemoDreamer

Travis is failing on:

An error occurred while installing capybara-webkit (0.3.0), and Bundler cannot

continue.

Are you sure Travis ever worked for you? I see from the previous pull-request builds in your queue that bundler was always failing: https://travis-ci.org/joshuaclayton/blueprint-css/builds/3804122

nemoDreamer avatar Apr 10 '14 18:04 nemoDreamer

Any news on fixing the Travis config?

nemoDreamer avatar Jun 10 '14 17:06 nemoDreamer

This and all other pull-requests will fail, since the base build in https://github.com/joshuaclayton/blueprint-css/tree/master is broken. Attempting to fix it in #21.

nemoDreamer avatar Jan 16 '15 18:01 nemoDreamer