canvas2pdf icon indicating copy to clipboard operation
canvas2pdf copied to clipboard

Published 20 hours ago • verified publisher icon joshua-gould

AMD dependency for PDFDocument

Open mateuszluczak opened this issue 6 years ago • 1 comments

Your library works great, but we've encountered a problem when used with AMD and require.js.

You are explicitly calling for global PDFDocument, which causes a problem as this dependency should be defined in define for AMD. pdfkit also supports AMD so it's not possible to shim it to global without ugly exposing PDFDocument to global.

Would be great if you could fix this, or let me know if you are open to PRs.

mateuszluczak avatar Aug 03 '18 08:08 mateuszluczak

Sorry for the delay in my response. It would be great if you submitted a PR that fixed this issue. Thanks.

joshua-gould avatar Aug 06 '18 21:08 joshua-gould